Skip to content

content-length is not policed when a stream ends with a trailers section #1328

Description

@feiiiiii5

Summary

A stream that ends with a trailers section never has its content-length policed, and a content-length in the trailers silently overrides the one declared in the header section.

Description

H2Stream.receive_headers is the handler for every received HEADERS block — initial headers, informational responses and trailers. It called self._initialize_content_length(headers) unconditionally. But _track_content_length, which is where the actual comparison happens, was only ever called from receive_data:

if expected is not None:
    if expected < actual:
        raise InvalidBodyLengthError(expected, actual)

    if end_stream and expected != actual:
        raise InvalidBodyLengthError(expected, actual)

Trailers never go through receive_data, so end_stream is never True here and the short-body check never runs. Two concrete consequences:

  • Trailers without content-length: _initialize_content_length sets _expected_content_length back to None, so if expected is not None: skips validation altogether.
  • Trailers with content-length: the trailers value replaces the header-section value, so a peer could declare content-length: 10 in the headers and content-length: 3 in the trailers and have a 13-byte body accepted.

The too-much-data direction still errors, because expected < actual trips while receiving DATA frames. Only the short-body direction is silently accepted.

RFC 9113 § 8.1.1

A request or response is also malformed if the value of a content-length header field does not equal the sum of the DATA frame payload lengths that form the content, unless the message is defined as having no content. For example, 204 or 304 responses contain no content, as does the response to a HEAD request.

Malformed requests or responses that are detected MUST be treated as a stream error of type PROTOCOL_ERROR.

The listed exemptions are 204, 304 and HEAD. A trailers section is not one of them. This is the same check the project adopted in #123 ("Police content lengths when provided"), proposed in #114.

Steps to reproduce

Unit level, no network, in-memory bytes:

scenario result on 4.4.1
content-length: 3, DATA 10, END_STREAM on DATA InvalidBodyLengthError
content-length: 15, DATA 13, END_STREAM on DATA InvalidBodyLengthError
content-length: 15, DATA 13, trailers END_STREAM accepted
content-length: 15, no DATA, trailers END_STREAM accepted
content-length: 15, DATA 13, trailers content-length: 13 accepted

Existing coverage only exercises the DATA-frame case: test_insufficient_data and test_insufficient_data_empty_frame in tests/test_invalid_content_lengths.py.

Environment

  • h2 4.4.1, master at bc239af1d1b85bc70482804f30a0e0e587d90a08
  • Python 3.14, macOS

Fix

In receive_headers, when the block is trailers: run the same content-length parse so a syntactically invalid value there is still a ProtocolError, then restore the previous expectation, and finally validate the body where the stream actually ends.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions