Skip to content

Use license field of pyproject.toml only for this package - #259

Open
slivingston wants to merge 1 commit into
python-control:masterfrom
slivingston:pkg-license
Open

slivingston wants to merge 1 commit into
python-control:masterfrom
slivingston:pkg-license

Conversation

@slivingston

Copy link
Copy Markdown
Member

This PR is a very small patch to #252 so that the license field of pyproject.toml gives the license of this package, not its dependencies. When creating distributions that include dependencies, respective licenses are bundled as separate LICENSE files.

@moorepants Does that match your understanding of how to indicate the license in wheels? I ask because you commented on the relevant PR previously.

Closes #258

The modification of `license` in commit 70e0137
is reverted because most users recognize `license` as referring to this package,
not its dependencies. When creating distributions that include dependencies,
it is sufficient to include respective licenses as separate LICENSE files.

Closes python-control#258
@moorepants

Copy link
Copy Markdown
Contributor

Given that BSD is compatible with GPL, my understanding is that slycot would simply be licensed as GPL. You'd have to figure out whether that is GPL 2 or 3 and whether the gcc exception is included. A website like https://licensecompat.com/ is helpful to figure out the final license that encompasses all compatibilities.

@slivingston

Copy link
Copy Markdown
Member Author

Given that BSD is compatible with GPL, my understanding is that slycot would simply be licensed as GPL. You'd have to figure out whether that is GPL 2 or 3 and whether the gcc exception is included. A website like https://licensecompat.com/ is helpful to figure out the final license that encompasses all compatibilities.

@moorepants Sorry, I was not clear in my question. I believe that license in pyproject.toml should have the license of the package itself only. When bundling wheels, the licenses of dependencies should be indicated in some other way, like LICENSE text files, not by adding a dependency's license to license in pyproject.toml. Do you agree?

In PR 252, the author wrote

I have also changed the "license" field in pyproject.toml to account for all the dependencies, though I see other projects, e.g., scipy-openblas64, don't do that: the license field seems to only refer to the project's "own" code.

and you reacted with 👍 , so I am asking now to confirm standard practice (in your view) of making wheels.

@roryyorke

Copy link
Copy Markdown
Collaborator

ugh, sorry. I forked your branch to test the conda failure, and pushed to it instead of my copy. I'm going to force push to fix it.

@roryyorke
roryyorke force-pushed the pkg-license branch 2 times, most recently from f48b9e7 to badf66c Compare October 24, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

license: Where does GPL-3.0-with-GCC-exception come from?

3 participants