Skip to content

fix(engine): decide day or night per frame and skip frozen frames - #459

Open
MateoLostanlen wants to merge 4 commits into
developfrom
fix/engine-day-night-per-frame
Open

MateoLostanlen wants to merge 4 commits into
developfrom
fix/engine-day-night-per-frame

Conversation

@MateoLostanlen

Copy link
Copy Markdown
Member

Part of pyronear/roadmap#16, engine side of #422.

  • Night patrols were only stopped when already stopped (inverted condition), so they ran all night. They are now stopped when running.
  • Day or night was decided from the last frame of the loop, so one stale or infrared frame could put the whole site to sleep in daylight. Each frame is now checked: night frames are not analyzed, and the site sleeps only when every frame of the pass is a night frame. A night frame also drops the camera's detection history, so evening frames are not combined with the next morning's.
  • A frame identical to the previous one for the same pose is skipped. A frozen camera at Epinay re-uploaded the same false positive every 30 s for 9 days.

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.81%. Comparing base (a2604d4) to head (b1c525d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
+ Coverage    80.51%   83.81%   +3.29%     
===========================================
  Files            6        6              
  Lines          847      865      +18     
===========================================
+ Hits           682      725      +43     
+ Misses         165      140      -25     
Flag Coverage Δ
unittests 83.81% <100.00%> (+3.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant