Skip to content

fix(stream): restore the pre-stream zoom on every stream stop - #432

Open
MateoLostanlen wants to merge 1 commit into
developfrom
fix/restore-zoom-on-stream-stop
Open

MateoLostanlen wants to merge 1 commit into
developfrom
fix/restore-zoom-on-stream-stop

Conversation

@MateoLostanlen

Copy link
Copy Markdown
Member

Stacked on #431. Switch the base to develop once #431 is merged.

  • Replacing a stream with another one and the idle stopper stopped streams without touching the zoom. Only /stop_stream restored it.
  • The saved zoom, the restore and the stream lock move into services/stream, so stop_any_running_stream handles all three paths.
  • Side effect on PTZ cameras: after an idle stop or a replacement, they go back to their pre-stream zoom instead of staying zoomed.

Base automatically changed from feat/motorised-lens-detection to develop October 22, 2026 08:51
Replacing a stream in start_stream and the idle stopper stopped streams without touching the zoom; only /stop_stream restored it. Move the saved zoom, the restore and the stream lock into services/stream so stop_any_running_stream handles all three paths.
@MateoLostanlen
MateoLostanlen force-pushed the fix/restore-zoom-on-stream-stop branch from c3158d2 to ebf8e37 Compare October 26, 2026 18:59
@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.51%. Comparing base (9210e3b) to head (ebf8e37).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #432   +/-   ##
========================================
  Coverage    80.51%   80.51%           
========================================
  Files            6        6           
  Lines          847      847           
========================================
  Hits           682      682           
  Misses         165      165           
Flag Coverage Δ
unittests 80.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant