Repository navigation
fix(stream): restore the pre-stream zoom on every stream stop - #432
Open
MateoLostanlen wants to merge 1 commit into
Open
MateoLostanlen wants to merge 1 commit into
MateoLostanlen wants to merge 1 commit into
Conversation
Replacing a stream in start_stream and the idle stopper stopped streams without touching the zoom; only /stop_stream restored it. Move the saved zoom, the restore and the stream lock into services/stream so stop_any_running_stream handles all three paths.
MateoLostanlen
force-pushed
the
fix/restore-zoom-on-stream-stop
branch
from
October 26, 2026 18:59
c3158d2 to
ebf8e37
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #432 +/- ##
========================================
Coverage 80.51% 80.51%
========================================
Files 6 6
Lines 847 847
========================================
Hits 682 682
Misses 165 165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #431. Switch the base to develop once #431 is merged.