Skip to content

ci: remove the PyPI publish workflow - #722

Open
MateoLostanlen wants to merge 2 commits into
mainfrom
chore/remove-pypi-publish
Open

MateoLostanlen wants to merge 2 commits into
mainfrom
chore/remove-pypi-publish

Conversation

@MateoLostanlen

Copy link
Copy Markdown
Member
  • The client is no longer published on PyPI, so the release-triggered publish workflow is removed. It has failed on every release since 2022: the version env was never applied and PyPI rejects the username/password upload.
  • Remove the PyPI badges from both READMEs and replace the pip install pyroclient instructions with the install-from-source path.
  • Align the documented Python prerequisite with the client pyproject.toml (3.10).
  • client/setup.py and pyproject.toml are unchanged; CI still installs the client in editable mode.

The client is no longer published on PyPI. Every release run of this
workflow has failed since 2022: the version env was never applied and
PyPI rejects the username/password upload.
Point users to the install-from-source path and align the Python
prerequisite with pyproject.toml.
@github-actions github-actions Bot added the topic: docs Improvements or additions to documentation label Oct 22, 2026
@MateoLostanlen
MateoLostanlen requested review from fe51 and frgfm October 22, 2026 13:48
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.70%. Comparing base (219cfac) to head (6687a11).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #722   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files          60       60           
  Lines        3266     3266           
=======================================
  Hits         3093     3093           
  Misses        173      173           
Flag Coverage Δ
backend 94.85% <ø> (ø)
client 91.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frgfm

frgfm commented Oct 22, 2026

Copy link
Copy Markdown
Member

Sounds good if we want to remove this! Just one thing: we could update the automated pypi release (the release process from github has changed, just need to update it). The question is whether we should keep those on pypi?

Open question. On one side, we could say that there is no reason not to. And on the other part is our backend API is open source, but most citizens or developers don't have any specific daily use of our API client. So supposedly it's only for internal systems. What do you think we should do? 🤷

@MateoLostanlen

Copy link
Copy Markdown
Member Author

Thanks! I removed it because the publish has been failing on every release since 2022 and nobody noticed, so I assumed nobody relies on the PyPI package (internal systems install from git). Fixing it with trusted publishing would be easy, but someone would then have to maintain it.

Do you think it's worth keeping on PyPI? If not, I'd also yank the old releases so pip install pyroclient stops pulling a 2022 client that no longer matches the API.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants