Repository navigation
ci: remove the PyPI publish workflow - #722
MateoLostanlen wants to merge 2 commits into
Conversation
The client is no longer published on PyPI. Every release run of this workflow has failed since 2022: the version env was never applied and PyPI rejects the username/password upload.
Point users to the install-from-source path and align the Python prerequisite with pyproject.toml.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 60 60
Lines 3266 3266
=======================================
Hits 3093 3093
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Sounds good if we want to remove this! Just one thing: we could update the automated pypi release (the release process from github has changed, just need to update it). The question is whether we should keep those on pypi? Open question. On one side, we could say that there is no reason not to. And on the other part is our backend API is open source, but most citizens or developers don't have any specific daily use of our API client. So supposedly it's only for internal systems. What do you think we should do? 🤷 |
|
Thanks! I removed it because the publish has been failing on every release since 2022 and nobody noticed, so I assumed nobody relies on the PyPI package (internal systems install from git). Fixing it with trusted publishing would be easy, but someone would then have to maintain it. Do you think it's worth keeping on PyPI? If not, I'd also yank the old releases so |
pip install pyroclientinstructions with the install-from-source path.pyproject.toml(3.10).client/setup.pyandpyproject.tomlare unchanged; CI still installs the client in editable mode.