Repository navigation
Conversation
frgfm
requested review from
Chouffe and
MateoLostanlen
and removed request for
Chouffe
October 22, 2026 10:24
Member
Author
|
Unfortunately, I just realized that there is no preview from Vercel or something else. So because this is changing the major version of Node, I think we should just run some short QA on the interface. There are no patched version on Node 18, so we can't afford to keep it. The closest version with a patch is version 22. This review should be a bit more thorough because of that major version change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node.js 18 is end of life and has no patched release for these issues. The 21 October 2026 security release fixes the eMudhra intermediate CA compromise and other Node.js vulnerabilities, with patches for Node.js 22, 24, and 26. Node.js 22.23.4 is the smallest patched major. This pins frontend CI and the Docker builder to 22.23.4, updates the
node_modulescache key, and aligns the frontend docs.Test plan
npm cipassed on Node 22.23.4 / npm 10.9.9. npm reports 39 dependency audit findings in the unchanged lockfile.npm run build,npm run test:coverage -- --maxWorkers=2 --minWorkers=1, andnpm run quality:cipassed. The build reports existing Browserslist age and bundle-size warnings.docker manifest inspect node:22.23.4-alpinepassed. A full Docker build could not run because the Docker daemon is unavailable.