Repository navigation
Add geometric solar position method to get_solarposition - #2915
Open
divyanshisingh987456321 wants to merge 2 commits into
Open
divyanshisingh987456321 wants to merge 2 commits into
divyanshisingh987456321 wants to merge 2 commits into
Conversation
Hey @divyanshisingh987456321! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content Finally, be sure the PR description includes the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Adds
pvlib.solarposition.geometric, a fast but approximate solar position calculation, and makes it available asmethod='geometric'inget_solarposition, as requested in #2914.Approach
declination_spencer71,equation_of_time_spencer71).solar_zenith_analyticalandsolar_azimuth_analytical.apparent_zenithandapparent_elevationequalzenithandelevation. This is stated in a warning in the docstring.ephemeris.Accuracy: compared with
spa_pythonhourly over all of 2026 at four sites (Golden, Gurugram, Sydney, Tromsø). The maximum zenith difference was about 0.6 degrees and the maximum daytime azimuth difference about 1 degree.Tests added in
tests/test_solarposition.py: comparison with SPA at the four sites above, output columns and ranges, naive times treated as UTC, and dispatch throughget_solarposition.Open design questions (also asked in #2914):
method='geometric'the right interface, or should it be something else?geometricbe a public function likeephemeris, or private?apparent_*columns be returned, or omitted since refraction is neglected?I used an AI assistant (Claude) to help draft this change. I reviewed the code, ran the tests locally and take responsibility for it.