Repository navigation
Clip beam projections before multiplying by irradiance - #2913
Noumenon-ai wants to merge 2 commits into
Conversation
Hey @Noumenon-ai! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content Finally, be sure the PR description includes the PR |
RDaxini
left a comment
There was a problem hiding this comment.
Finally, be sure the PR description includes the PR checklist, and complete the items you are able to.
This PR is not in compliance with the contributing guidelines and may be closed if the guidelines are not followed.
As far as I understand, #2903 never discussed changing the variable name beam into projection either, which gives me the impression that the following guideline:
If AI is used for any portion of this PR, you must vet the content for technical accuracy.
was also not followed because this appears to be an automated job with no expert oversight from the contributor.
FYI: Adherence to the basic guidelines at least gives reviewers some confidence in contributor commitment and engagement if they invest the time to review.
|
Thanks for the review, and sorry for the noise. You're right: this was opened by an automated tool, and the fix takes one side of a design question the issue thread hasn't settled. Closing it. If the team agrees on an approach, I'm happy to send a hand-checked PR that follows the guidelines. |
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.No API changes, so the reference docs item is removed.
Negative DNI measurements produce positive beam irradiance when the sun is behind the array.
Cause:
beam_componentandpoa_componentsclip the irradiance product instead of the solar projection.Fix: clip the projection (cosine of AOI) at zero first, then multiply by DNI, so beam is zero whenever the sun is behind the surface.
Coverage: regression tests for both functions with numpy arrays and pandas Series.