[jguz-pubnub]

No description provided.

[pubnub-snyk-universal-prd]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[parfeon]

It looks good but I think demo can be improved to use new subscription approach through subscription and subscription set. Can you please verify example and use if it fits?

[parfeon]

What it we would use newer approach for demo which utilize Subscription / SubscriptionSet?

Suggested change

	try:
	pubnub.subscribe().channels("hello_world").execute()
	if not listener.connected.wait(timeout=10):
	raise TimeoutError("Timed out waiting for the subscription to connect")
	pubnub.publish().channel("hello_world").message("Hello world").sync()
	if not listener.received.wait(timeout=10):
	raise TimeoutError("Timed out waiting for the message")
	finally:
	pubnub.unsubscribe().channels("hello_world").execute()
	pubnub.remove_listener(listener)
	pubnub.stop()
	subscription = pubnub.channels("hello_world").subscription()
	try:
	subscription.subscribe()
	if not listener.connected.wait(timeout=10):
	raise TimeoutError("Timed out waiting for the subscription to connect")
	pubnub.publish().channel("hello_world").message("Hello world").sync()
	if not listener.received.wait(timeout=10):
	raise TimeoutError("Timed out waiting for the message")
	finally:
	subscription.unsubscribe()
	pubnub.remove_listener(listener)
	pubnub.stop()

Will this work for us?

[jguz-pubnub]

Yes, I will use an example with Subscription

[parfeon]

It looks good but I think demo can be improved to use new subscription approach through subscription and subscription set. Can you please verify example and use if it fits?