Repository navigation
Add category-level permissions for App Context enumeration - #236
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
jguz-pubnub
changed the title
parfeon
left a comment
parfeon
left a comment
There was a problem hiding this comment.
From categories specs it looks like we need to have few checks added into validation method.
| if self._categories: | ||
| params['category'] = utils.join_items(self._categories) | ||
|
|
There was a problem hiding this comment.
validate_params method doesn't have verification for the case when user specify categories we need to ensure that auth has been passed as well as required.
No check on what exactly has been passed for the categories and there is only channels and uuids allowed.
Also, if categories not empty we need to verify that only get permissions has been granted.
There was a problem hiding this comment.
Does the server already enforce these rules? I see the spec documents a 400 for each case with a distinct message. Anyway, I'll add these validations
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
3 participants
feat(pam): add category-level permissions for App Context enumeration