Repository navigation
Split up plugin and stream contexts. - #110
Conversation
|
This is stacked on #91, so please review only the last commit. |
|
FWIW, the more I look at this, the more I think that we should implicitly create context as part of "new" callback, which would save one call into VM, and it would match callouts, since we implicitly create new context as part of sending the call. Change from: to: The main reason for the See previous discussion in #9. |
|
Recording discussion elsewhere, we decided that |
Notable changes: 1) Removed `proxy_on_vm_start` callback. 2) Split plugin lifecycle from stream context lifecycle. 3) Consolidated `proxy_on_done`, `proxy_on_log`, and `proxy_on_delete` into `proxy_on_context_finalize`. Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
b06d37d to
04401f6
Compare
|
Unstacked after #91 was merged, no other changes were made. |
Notable changes:
proxy_on_vm_startcallback.proxy_on_done,proxy_on_log, andproxy_on_deleteinto
proxy_on_context_finalize.