Repository navigation
chore: Update libsveltos so clusters with connection down are skipped - #2028
Merged
Merged
Conversation
libsveltos now treats a SveltosCluster whose connection is down as not ready to be configured (Status.Ready stays true while the connection is down, so it was not caught before) and reconciles when the connection is back. Pull mode is unaffected: its connection status mirrors the agent heartbeat, which is already verified separately. addon-controller already uses IsClusterReadyToBeConfigured to decide whether to process a cluster, so with this bump it no longer tries to collect ResourceSummaries from, or upgrade drift-detection-manager in, a cluster that cannot be reached. That removes the repeated "failed to collect ResourceSummaries: compatibility checks failed" and i/o timeout logs for a down cluster. Add a unit test so skipCollecting keeps skipping such a cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libsveltos now treats a SveltosCluster whose connection is down as not ready to be configured (Status.Ready stays true while the connection is down, so it was not caught before) and reconciles when the connection is back. Pull mode is unaffected: its connection status mirrors the agent heartbeat, which is already verified separately.
addon-controller already uses IsClusterReadyToBeConfigured to decide whether to process a cluster, so with this bump it no longer tries to collect ResourceSummaries from, or upgrade drift-detection-manager in, a cluster that cannot be reached. That removes the repeated "failed to collect ResourceSummaries: compatibility checks failed" and i/o timeout logs for a down cluster.
Add a unit test so skipCollecting keeps skipping such a cluster.