Repository navigation
feat: Report drifted resources in ClusterSummary - #2024
Merged
gianlucam76 merged 1 commit intoOct 8, 2026
Merged
Conversation
gianlucam76
force-pushed
the
drift-resource-identity
branch
from
October 8, 2026 17:54
1ed671f to
7ace0d8
Compare
Fixes projectsveltos#1940 Two changes that go together: say which resources drifted, and give pull mode the same per-chart behavior as push mode. drift-detection now lists the drifted resources in ResourceSummary.status.driftedResources. addon-controller records them in the ClusterSummary: - New FeatureSummary.lastDrift: detectedTime, the drifted resources (group, kind, namespace, name, and for Helm the release name and namespace), and a truncated flag when more than 20 drifted. - Kept after the drift is corrected and replaced by the next drift. Only set for ContinuousWithDriftDetection. - After a drift is recorded, driftedResources and driftedResourcesTruncated are cleared on the ResourceSummary. drift-detection only appends and skips a resource already listed, so without this the detectedTime stays pinned to the first drift. In pull mode every chart of a profile was staged and re-applied by sveltos-applier on any change or drift. Now: - HelmChartSummary tracks appliedContentHash (what sveltos-applier last confirmed as applied) and stagedContentHash (staged, not yet confirmed). The hash covers the rendered resources and the settings that change how they are applied. - A chart whose hash matches the applied one, and that drift-detection did not report, is staged with ConfigurationBundle skipApply, so sveltos-applier leaves it alone. Skipped bundles are still reported, so the applier's cleanup and ResourceSummary stay correct. - A chart is never skipped while a staged hash is pending, so a failed apply is retried. - A chart staged because it yielded to a lower tier profile is always applied: that is how the owner tier is updated on its resources. - Push mode is unchanged.
gianlucam76
force-pushed
the
drift-resource-identity
branch
from
October 8, 2026 18:30
7ace0d8 to
f8e092b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1940
Two changes that go together: say which resources drifted, and give pull mode the same per-chart behavior as push mode.
drift-detection now lists the drifted resources in ResourceSummary.status.driftedResources. addon-controller records them in the ClusterSummary:
In pull mode every chart of a profile was staged and re-applied by sveltos-applier on any change or drift. Now: