Skip to content

Add support for wix files - #585

Merged
asottile merged 1 commit into
pre-commit:mainfrom
Kvan7:patch-1
Sep 26, 2026
Merged

asottile merged 1 commit into
pre-commit:mainfrom
Kvan7:patch-1

Conversation

@Kvan7

@Kvan7 Kvan7 commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Adds commonly used wix file extensions: wixproj, wxs, wxi, wxl

Wix is a toolset for creating msi installers, https://github.com/wixtoolset/wix

@Kvan7

Kvan7 commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

I couldn't find great docs newer versions of wix, but the file extensions have stayed the same from what I can tell.
(also not an expert in wix)
https://docs.firegiant.com/wix3/overview/files/
there are also some linking/output files but I didn't include them in this since I have never touched them myself & they have less than 50 results when searching the file types on github

Comment thread identify/extensions.py Outdated
'wav': {'binary', 'audio', 'wav'},
'webp': {'binary', 'image', 'webp'},
'whl': {'binary', 'wheel', 'zip'},
'wixproj': {'text', 'xml', 'wix'},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like these shouldn't all have the same tag since semantically the extensions mean different things?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had just done them all with the same since they were related & to group them. I don't really have much preference though so I can change them to be individual if that matches the convention other files use better

Adds commonly used wix file extensions. Wix is a toolset for creating msi installers

https://github.com/wixtoolset/wix

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile
asottile merged commit d28c571 into pre-commit:main Sep 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants