fix: tokenize multiplication in nested calc parentheses - #102
Open
DeepanshuPal wants to merge 2 commits into
Open
DeepanshuPal wants to merge 2 commits into
DeepanshuPal wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86.
Inside anonymous parentheses under
calc(), multiplication without spaces was left inside a word token. Forcalc((-1*var(--a))), that also made-1*varlook like a function name. Keep thecalccontext for anonymous parentheses, split the*token there, and leave nested named functions such asvar()unchanged.Added AST regressions for both reported examples and the nested
var()boundary. Validation:pnpm test(169 passed),pnpm lint,pnpm exec oxfmt --check lib/parse.js test/parse.js, andgit diff --check.