Repository navigation
Add expiration date parameter to sharing link commands - #5489
Open
gautamdsheth wants to merge 1 commit into
Open
gautamdsheth wants to merge 1 commit into
gautamdsheth wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The assignments cannot compile until PnP.Core supports the property, and the PR description references the wrong issue.
3 open findings
What changed in this PR
Adds optional expiration dates to user-specific file and folder sharing links.
Changes:
- Adds
-ExpirationDateTimeto both cmdlets. - Updates examples and parameter documentation.
- Adds a changelog entry.
| File | Description |
|---|---|
AddFolderUserSharingLink.cs |
Passes folder-link expiration options. |
AddFileUserSharingLink.cs |
Passes file-link expiration options. |
Add-PnPFolderUserSharingLink.md |
Documents folder-link expiration. |
Add-PnPFileUserSharingLink.md |
Documents file-link expiration. |
CHANGELOG.md |
Records the new parameter. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #1895
Depends on: pnp/pnpcore#1896
What is in this Pull Request ?
-ExpirationDateTimeparameter toAdd-PnPFileUserSharingLinkandAdd-PnPFolderUserSharingLinkto allow links to expire after a specified date.