Skip to content

Fix: use a unique temporary file for the error CSV export - #675

Merged
Rom1-B merged 2 commits into
mainfrom
fix_injection_export
Oct 5, 2026
Merged

Rom1-B merged 2 commits into
mainfrom
fix_injection_export

Conversation

@stonebuzz

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes #N/A
  • The "Export the log" action wrote the rejected lines to a file named after the uploaded CSV, so two exports using the same file name could overwrite and remove each other's file.
  • The export now writes to a unique temporary file in the plugin upload directory and is always downloaded as Errors.csv.

Screenshots (if appropriate):

@stonebuzz
stonebuzz force-pushed the fix_injection_export branch 8 times, most recently from 055831f to be0407f Compare September 30, 2026 15:04
@stonebuzz
stonebuzz requested a review from Rom1-B October 2, 2026 13:18
@stonebuzz stonebuzz self-assigned this Oct 2, 2026
@stonebuzz stonebuzz added the bug label Oct 2, 2026
Comment thread tests/unit/ClientInjectionWriteErrorsCsvTest.php
@stonebuzz
stonebuzz force-pushed the fix_injection_export branch from 43bb0f0 to 49326db Compare October 5, 2026 12:17
@Rom1-B
Rom1-B merged commit 33c7672 into main Oct 5, 2026
7 checks passed
@Rom1-B
Rom1-B deleted the fix_injection_export branch October 5, 2026 12:23
@stonebuzz stonebuzz mentioned this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants