Conversation
Lexachoc
changed the title
scatterglscattergl
Lexachoc
marked this pull request as draft
September 24, 2026 09:40
Lexachoc
marked this pull request as ready for review
September 24, 2026 09:40
Contributor
Author
|
I think there was an issue with GitHub yesterday that caused many of the checks to fail. However, I can't seem to find an option to re-run the failed checks. |
camdecoster
requested changes
Sep 25, 2026
camdecoster
left a comment
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix! Your update solves the problem. When I was reviewing, I found a helper function that could simplify this a bit. Let me know what you think.
Could you please add a unit test that covers these functions?
Contributor
Author
|
I applied your suggestion and added unit tests for the marker symbol detection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8070
Fix marker variant detection in
scatterglfor numeric (100,200, and300) and numeric-string ('100','200'and'300') symbol values.This PR makes numeric (numeric-string) symbol representations behave consistently with their named equivalents for
scattergland all WebGL-based traces that reuse its marker handling.