Repository navigation
Conversation
RuudBurger
approved these changes
Oct 28, 2026
DouweBos
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
On a physical Apple TV, every view hierarchy request stopped the driver. The handler queried the home screen (
com.apple.HeadBoard) for status bars and for the device frame, but a physical Apple TV's home screen answers only while it is in the foreground, so the status bar query failed (kAXErrorServerNotFound, orTimed out while evaluating UI query) and took the driver down with it.On tvOS the handler now skips the status bars, which tvOS does not have, and takes the device frame from the foreground app. iOS is unchanged.
Testing
I built the tvOS driver twice, once from this branch and once from
main, and ran the three flows ine2e/workspaces/tvos_demo_appagainste2e/tvos_demo_appwith each, using the Maestro 2.8.0.5 CLI.Notes on the setup:
tvos_demo_appstops at launch on tvOS 27, which requires the UIScene lifecycle. For these runs it got aSceneDelegatethat adopts the window React Native creates, and aUIApplicationSceneManifestin itsInfo.plist; that change is not part of this PR.launchAppis not implemented on a physical device yet, so the device runs launched the app withdevicectland skipped the flows' firstlaunchApp: clearState: true.tvos-focus-flowloses its first key press when it presses before the app has focus (it passes once it first asserts the focused button), andtvos-text-input-flowfails at"Typed: Maestro". Both happen withmaintoo.No e2e test is added: the tvOS e2e suite runs on simulators, which do not have this failure.
Issues fixed
None filed.