[do not merge] Print worker-mechanism diagnostics in the static analysis jobs - #6594
Closed
SanderMuller wants to merge 4 commits into
Closed
SanderMuller wants to merge 4 commits into
SanderMuller wants to merge 4 commits into
Conversation
Temporary, for a throwaway draft PR: on ubuntu the PHP 8.2+ jobs spawn their workers while 7.4-8.1 fork them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
On ubuntu the PHP 8.2+ jobs have neither extension, so parallel analysis spawns its workers there instead of forking them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The runner's php.ini for PHP 8.2+ disables the pcntl_* functions, so parallel analysis spawned its workers there even with pcntl loaded. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing: the diagnostics found the cause, and #6595 has the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway, not for merging. I will close it once the jobs have run.
On ubuntu, the self-analysis jobs for PHP 7.4, 8.0 and 8.1 fork their workers. The jobs for 8.2–8.6 spawn them: the run for 9c49ae3 prints
largest of 4 spawned workersthere. A source checkout should fork. pcntl is available, it is not a phar, and setup-php does not setopcache.enable_cli, so JIT should not be live either.It matters for memory too. In that run the 7.4 and 8.0 main process is 162–164 MB on ubuntu, where it forks, and 210–212 MB on Windows, where it spawns. On 8.2+, where both spawn, the two differ by only 5–7 MB.
This adds one step before PHPStan. It prints
bin/phpstan diagnose(itsReason fork not usedline),php --ini, and the pcntl and OPcache state that the fork check depends on.🤖 Generated with Claude Code