Skip to content

Support non-decimal-int-string - #308

Merged
jaapio merged 2 commits into
phpDocumentor:2.xfrom
oleibman:TypeResolver2
Sep 27, 2026
Merged

jaapio merged 2 commits into
phpDocumentor:2.xfrom
oleibman:TypeResolver2

Conversation

@oleibman

@oleibman oleibman commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

See phpDocumentor/phpDocumentor#4147, which has been open for 3 months without acknowledgment. The fix apparently belongs here.

Allow the use of two new types recently added to phpstan https://phpstan.org/blog/phpstan-2-2-unsealed-array-shapes-safer-array-keys#safer-array-keys

See phpDocumentor/phpDocumentor#4147, which has been open for 3 months without acknowledgment. The fix apparently belongs here.

Allow the use of two new types recently added to phpstan https://phpstan.org/blog/phpstan-2-2-unsealed-array-shapes-safer-array-keys#safer-array-keys

@jaapio jaapio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this fix! I'm sorry that you had to wait so long.

@jaapio

jaapio commented Sep 27, 2026

Copy link
Copy Markdown
Member

Can you please have a look at the phpcs errors?

Error: Class name doesn't match filename; expected "class NonDecimalIntString"
Error: Class name doesn't match filename; expected "class DecimalIntString"
Error: Process completed with exit code 1.

You can ignore the other failing action, I will handle this.

Class name did not agree with member name.
@oleibman

Copy link
Copy Markdown
Contributor Author

I believe my recent push 2de297d will resolve the phpcs problems.

@jaapio
jaapio merged commit dbe2133 into phpDocumentor:2.x Sep 27, 2026
26 of 27 checks passed
@jaapio

jaapio commented Sep 27, 2026

Copy link
Copy Markdown
Member

Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants