Fix GH-23899: Handle bailout from ZipArchive cancel callback return v… - #23914
Open
LamentXU123 wants to merge 2 commits into
Open
LamentXU123 wants to merge 2 commits into
LamentXU123 wants to merge 2 commits into
Conversation
devnexen
reviewed
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…alidation
Now, PHP 8.6 moved archive closing from free_obj to dtor_obj as a result that callbacks can run before the executor shuts down.If a cancel callback returns an invalid type during shutdown, it can cause assertion error.
Well PHP 8.5 closes the archive in free_obj, which is already marked as called so it does not have this double-release path. Here, we just catch the bailout from return-type validation using the existing bailout_callback mechanism