573 - Check URLs are valid before attempting to perform HTTP request - #578
Open
markfullmer wants to merge 3 commits into
Open
markfullmer wants to merge 3 commits into
markfullmer wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #573
Implementation
Adds a new
isValidUrl()helper function that:FILTER_VALIDATE_URLdns_get_record()to check if a record existsdns_get_record()fails, trygethostbyname()This helper function is added to Extractor::resolveUri(), adjacent to the check for HTTP URLs.
Finally, the existing
isHttp()function is updated to use a stricter "allow-list" methodology, rejecting anything that does not match the http or https schema, as suggested in #573.Test coverage
Test coverage is added in FunctionsTest. All of its scenarios pass. There are other failing tests, but these are unchanged compared to the failing tests prior to this code change.