Repository navigation
fix: address iTerm by bundle identifier - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finder launches that select iTerm2 currently fail while compiling the runtime AppleScript with
Expected end of line but found class nameatcreate window ....The terminal detector already identifies iTerm by its stable bundle identifier (
com.googlecode.iterm2), but the AppleScript addresses the app by the hard-coded nameiTerm2. Installations commonly use the bundle nameiTerm.app, soosascriptcan fail to load iTerm's scripting dictionary and then parseswindowas an unknown class.Use
application id "com.googlecode.iterm2"for both the running-state check and thetellblock. This keeps the runtime AppleScript aligned with the existing bundle-ID-based detection and avoids dependence on the app's filename/display name.