Repository navigation
feat: publish a sha256 checksums file with each release (#623) - #657
Merged
Merged
Conversation
Add a "Generate checksums" step to the release job that hashes every downloaded artifact (binaries, .deb, .rpm) and writes pgschema-<version>-checksums.txt in sha256sum format, then attach it to the GitHub release. Version managers such as proto can point at it to verify prebuilt binaries. Document how to verify a download in docs/installation.mdx, and fix the Linux pre-built binary URLs there, which omitted the version from the asset name. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The checksum workflow has supporting verification evidence, with only a minor documentation clarification remaining.
1 open finding
What changed in this PR
Adds release checksum assets so users and version managers can verify pgschema downloads, addressing #623.
Changes:
- Generate and publish SHA-256 checksums for binaries and packages.
- Document download verification on Linux and macOS.
- Correct Linux binary asset URLs.
| File | Description |
|---|---|
| docs/installation.mdx | Adds verification instructions and fixes Linux download URLs. |
| .github/workflows/release.yml | Generates and uploads the release checksums file. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
 [Medium impact] The PR appears safe to merge. SummaryAdds a SHA-256 checksums file to each release and documents how to check downloads.
Reviews (2) · Last reviewed commit: "docs: note both version placeholders for..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #623
What
releasejob that runssha256sum */*over the downloaded artifacts and writespgschema-<version>-checksums.txtwith one<sha256> <asset name>line per binary,.deband.rpm, then attaches it to the GitHub release.docs/installation.mdxshowingsha256sum -c --ignore-missing(Linux) andshasum -a 256 -c --ignore-missing(macOS).pgschema-linux-amd64instead of the actual asset namepgschema-<version>-linux-amd64.Why
Version managers (e.g. proto) verify a download against a
sha256sum-format checksums file fetched from the release. Without one they install pgschema unverified. This is the same format golangci-lint and GoReleaser-based projects publish.Verification
Ran the step against a mock of the
binaries/<artifact>/<asset>layout the workflow downloads, using the real v1.13.2 asset names. The file lists all eight assets with the directory prefix stripped. From a directory holding the flat release assets,shasum -a 256 -c --ignore-missingpasses on untouched assets and reportsFAILEDwith a non-zero exit when an asset is modified.🤖 Generated with Claude Code