Repository navigation
Release 2.2.1: don't send internal addresses for texture packs - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Pterodactyl host, players got "Error 10061 when trying to download texture pack". The server sent an address players can't reach: either an internal allocation IP from
SERVER_IP, or the container's own address. Inside Docker every player comes from the container network, so the "same network" shortcut picked it.SERVER_IPis only used when it is a public IP.P_SERVER_UUID).publicAddressonce. When there is one, it logs the URL players download from.publicAddresson panels.Bumps the version to 2.2.1; merging publishes the release.