Repository navigation
PDFCLOUD-6233 Refine pdfRest client API skill contracts - #49
Merged
Merged
Conversation
Keep the generated lockfile out of toml-sort-fix while retaining the hook for other TOML files. Assisted-by: Codex
Use the container spec only when a requested new tool is absent from the cloud spec, keeping each operation tied to one documented contract. Assisted-by: Codex
- Recover exact string choices from the API contract and linked sources. - Expose known names alongside open strings when the service allows both. - Match tests and documentation to each catalog's actual behavior. Assisted-by: Codex
- Require known literals alongside open strings for documented names. - Distinguish closed-catalog coverage from open-name validation in tests. Assisted-by: Codex
- Investigate indirect value references instead of assuming free-form strings. - Report fallback sources, unresolved catalogs, and contract conflicts. Assisted-by: Codex
✅ Deploy Preview for pdfrest-python ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
datalogics-tsmith
approved these changes
Oct 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDFCLOUD-6233
Why this change
Follow up on PR #44, which merged the original pdfRest client API skill. Five additional commits authored on September 23 remained on the same branch. Comparing the pre-rebase history with this branch confirms all five patches are unchanged; the October 7 rebase placed them on top of the merged PR and changed their commit hashes.
What changed (high level)
The skill now discovers operations in the Cloud OpenAPI specification first, with the Container specification used only when a requested new tool is absent from Cloud. It requires investigation and disclosure of indirectly documented string constraints, distinguishes closed catalogs from known names within open string contracts, and aligns contributor and testing guidance with that distinction. The TOML sorting hook excludes the generated
uv.lockfile while continuing to apply to other TOML files.Behavior changes
Contributor guidance requires exact public literals for verified closed catalogs and documented known-name literals combined with
strfor open catalogs. It calls for explicit reporting of fallback sources and unresolved contract conflicts, with test expectations reflecting whether values are closed or deployment-dependent. SDK runtime behavior and public APIs are unchanged.Validation
The skill validator,
git diff --check, and applicable pre-commit hooks passed for the four changed files in an exported snapshot of head686764ef14e47ccb08697c60ecdd333b00eb1c2a. Checked that validation left those files byte-identical and that the TOML exclusion matchesuv.lockbut notpyproject.toml.git range-diffconfirms the five patches match their September 23 versions. Local Ruff, basedpyright, unit/live tests, and the full interpreter matrix were not run because no Python implementation or tests changed.Existing CI will run unit tests with coverage and live examples on Python 3.10–3.14, plus pre-commit, basedpyright, and a docs build. Diff coverage and the docs preview upload are PR-only; live tests run on Python 3.11 for PRs and scheduled runs. No workflow definitions changed.
Risks and follow-ups
This PR contains only the five commits beyond the merged PR #44; its four-file diff covers skill guidance, contributor/testing documentation, and the hook exclusion. Reviewers should verify the documented open-versus-closed contract policy. The hook exclusion is a separate tooling adjustment included in the existing branch. Hosted CI results remain pending.