Skip to content

chore: neutral wording for a reviewer credit in fixture_env.py #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperdew merged 1 commit into from
Oct 1, 2026
Merged

chore: neutral wording for a reviewer credit in fixture_env.py #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/ci/fixture_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def inside_the_sandbox(cwd: str | os.PathLike, _env: dict | None = None) -> None
A lint reads code; this runs. If the repository git would act on is not
under `cwd`, the fixture is about to configure or commit somewhere real, and
the honest moment to stop is before the first write, not after the gate
notices the identity in a later commit. (codex, #1647)
notices the identity in a later commit. (review, #1647)
"""
# _env breaks the recursion: sealed_env(cwd=…) calls this, so building a
# fresh environment here would call sealed_env again, for ever.
Expand Down
Loading