Skip to content

Fix duplicated partial changelog titles - #888

Merged
nforro merged 1 commit into
packit:mainfrom
nforro:fix
Oct 26, 2026
Merged

nforro merged 1 commit into
packit:mainfrom
nforro:fix

Conversation

@nforro

@nforro nforro commented Oct 26, 2026

Copy link
Copy Markdown
Member

Remove stale continuation lines when replacing changelog titles with canonical titles, preserving Jira reference lines and adding regression coverage.

Remove stale continuation lines when replacing changelog titles with
canonical titles, preserving Jira reference lines and adding regression
coverage.

Signed-off-by: Nikola Forró <nforro@redhat.com>
Assisted-by: GPT-5.6 Luna via OpenCode
@qodo-for-packit

Copy link
Copy Markdown

PR Summary by Qodo

Remove stale wrapped changelog titles during canonicalization

🐞 Bug fix 🧪 Tests 🕐 10-20 Minutes


AI Description

• Remove stale continuation lines when replacing a wrapped changelog title with its canonical title.
• Preserve Jira reference lines and add regression coverage for wrapped titles.
Diagram

graph TD
  A["New changelog entry"] --> B["Replace title"] --> C{"Indented continuation?"} -->|"Yes, not Jira"| D["Remove stale lines"] --> E["Preserve Jira refs"]
  C -->|"No or Jira"| E
Loading
High-Level Assessment

Removing continuations where the title is already canonicalized is the focused approach: it preserves the existing entry-count safeguard and Jira handling without introducing a separate changelog rewrite.

Files changed (2) +49 / -0

Bug fix (1) +9 / -0
tasks.pyDiscard stale title continuations during canonicalization +9/-0

Discard stale title continuations during canonicalization

• After replacing the descriptive line, removes consecutive indented continuation lines. Stops at Jira references or non-indented content so those lines remain in the entry.

ymir/agents/tasks.py

Tests (1) +40 / -0
test_tasks.pyCover wrapped titles followed by Jira references +40/-0

Cover wrapped titles followed by Jira references

• Adds a regression test confirming that canonicalization removes a wrapped title's continuation while retaining an indented Resolves reference.

ymir/agents/tests/unit/test_tasks.py

@qodo-for-packit

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Powered by Qodo

@nforro
nforro merged commit a05b3d2 into packit:main Oct 26, 2026
16 checks passed
@nforro
nforro deleted the fix branch October 26, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants