Repository navigation
Conversation
Malformed flags such as `--tags bad` already print a usage error and exit non-zero. Treat cmd.flagError as an expected exit path so it is not reported as a high-priority Sentry issue. Fixes CLI-Q Co-authored-by: TP Honey <thomas.honey@overmind.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigation (ENG-6795 / CLI-Q)
Still an issue in Sentry, but it is not firing right now. CLI-Q is unresolved. It has not occurred only once — Sentry and Honeycomb both show 2 events, both on 2026-10-16:
overmind changes submit-plan --tags badovermind terraform plan --tags nopeNo further
--tagsvalidation events since then (through 2026-10-26). The commands failed in ~1.2ms on local argument validation; there was no backend/outage. This looks like someone exercising invalid input, not a customer-facing incident.The same capture path also produced CLI-N (
invalid --timeout value 'nope', 276 events, last seen 2026-08-14). That issue is older and also unresolved.Root cause:
Execute()always calledsentry.CaptureExceptionafter a command error, including expectedcmd.flagErrorvalidation.Fix
flagErroras an expected exit path: print the existing usage/validation message, keep the non-zero exit, still record the span for Honeycomb, do not send it to Sentry.--tagsasflagError(invalid --tags value '…', expected format 'key=value') so that path uses the same expected-exit handling instead of a logged/Sentry error.overmind terraform plannow returns the parse error (non-zero exit) instead of swallowing it.Fixes https://overmindtech.sentry.io/issues/CLI-Q
Fixes CLI-Q
Fixes ENG-6795