Skip to content

Flaky test fix: Stop tracing the sender after the ack_sync check #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ostinelli merged 1 commit into from
Oct 13, 2026
Merged

Flaky test fix: Stop tracing the sender after the ack_sync check #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions test/syn_registry_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1722,13 +1722,14 @@ three_nodes_ack_sync_ordered_delivery(Config) ->
syn_test_suite_helper:connect_node(SlaveNode1),
syn_test_suite_helper:assert_scope_subcluster(registry,node(), scope_order, [SlaveNode1]),

%% stop tracing
erlang:trace(SenderPid, false, ['receive']),

%% verify that sender_loop received a {send_single, ...} message containing ack_sync.
%% this proves ack_sync is routed through sender_loop (the fix), ensuring FIFO
%% ordering with sync_register/sync_unregister broadcasts.
true = check_trace_for_ack_sync_via_sender().
true = check_trace_for_ack_sync_via_sender(),

%% stop tracing after the check: the node can show up in the subcluster
%% before the sender has received the queued ack_sync
erlang:trace(SenderPid, false, ['receive']).

three_nodes_ack_sync_reconciles_registry_snapshot(Config) ->
%% ack_sync contains a full snapshot for the remote node at its FIFO point.
Expand Down
Loading