Repository navigation
Make save_large_file robust to transient errors - #351
Closed
Sriram-Nambiar wants to merge 2 commits into
Closed
Sriram-Nambiar wants to merge 2 commits into
Sriram-Nambiar wants to merge 2 commits into
Conversation
Collaborator
|
@Sriram-Nambiar this is a duplicate of #349 ; I will hence close this PR in favor of the other one. I strongly recommend to comment on issue to be assigned before starting work, this avoids this kind of duplicate effort. I encourage you to contribute to #349 by reviewing code changes over there. Please also do not merge from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
wgetwith streamingrequestsand Range-based resume insave_large_file, fixing #348.wgettreats transient HTTP errors (502/503/504/429) and DNS failures as fatal, and its-tcounter is a budget for the entire download rather than consecutive failures without progress.This matches the solution settled in openzim/zimwright#7:
Rangerequests from the bytes on disk.429, 500, 502, 503, 504) and connection/timeout errors with backoff and jitter.Range(200 OK).Unit tests added covering all resume, retry, and failure scenarios.
Closes #348.