Skip to content

Remove deprecated 'convert' parameter from optimize_image (Fixes #292) - #350

Draft
Sriram-Nambiar wants to merge 1 commit into
openzim:mainfrom
Sriram-Nambiar:remove-deprecated-convert-optimize-image
Draft

Sriram-Nambiar wants to merge 1 commit into
openzim:mainfrom
Sriram-Nambiar:remove-deprecated-convert-optimize-image

Conversation

@Sriram-Nambiar

Copy link
Copy Markdown
Contributor

Fixes #292

Summary of Changes:

  • Removed deprecated convert parameter from optimize_image() and removed unused warnings import.
  • Removed deprecation test cases from tests/image/test_image.py.
  • Added entry in CHANGELOG.md under [Unreleased] -> Removed.

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9b47195) to head (74d2535).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #350   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         2708      2703    -5     
  Branches       401       399    -2     
=========================================
- Hits          2708      2703    -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure code coverage is still 100%

@Sriram-Nambiar

Copy link
Copy Markdown
Contributor Author

I'm out at the moment will fix the coverage gap and update the PR soon

@Sriram-Nambiar
Sriram-Nambiar force-pushed the remove-deprecated-convert-optimize-image branch from aad20f9 to 74d2535 Compare October 15, 2026 12:43
@benoit74
benoit74 marked this pull request as draft October 19, 2026 07:33
@benoit74

Copy link
Copy Markdown
Collaborator

Converting to draft, LGTM but we need to wait for a major release to be planned before merging this. Thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[next major] Remove deprecated 'convert' parameter for optimize_image function inside optimization.py

2 participants