Repository navigation
Support multi-archive search and SearchResult with snippets - #276
Open
Sriram-Nambiar wants to merge 1 commit into
Open
Sriram-Nambiar wants to merge 1 commit into
Sriram-Nambiar wants to merge 1 commit into
Conversation
benoit74
reviewed
Oct 20, 2026
Sriram-Nambiar
force-pushed
the
multi-archive-search-and-snippets
branch
from
October 20, 2026 12:57
94e18dd to
f90a269
Compare
benoit74
requested changes
Oct 20, 2026
benoit74
left a comment
benoit74
left a comment
Contributor
There was a problem hiding this comment.
We modify the SearchResultSet but this is OK since this will be a major release.
Please:
- mention this breaking change in CHANGELOG
- bump version in
pyproject.tomlto4.0.0-dev0so that we do not release this as a minor by mistake
Sriram-Nambiar
force-pushed
the
multi-archive-search-and-snippets
branch
from
October 20, 2026 15:06
f90a269 to
c35621f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230 Fixes #226
Support multi-archive searching in Searcher: can be initialized empty, with a list of archives, or populated via add_archive() (also aliased as addArchive()).
search.getResults() yields SearchResult objects exposing archive, path, title, and snippet (instead of just raw path strings).
SearchResult compares equal to str matching its path so existing code and tests expecting entry paths do not break.