Repository navigation
feat(dashboard): run filters #900
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| import { Button } from "@/components/ui/button"; | ||
| import { Field, FieldLabel } from "@/components/ui/field"; | ||
| import { Input } from "@/components/ui/input"; | ||
| import { | ||
| Select, | ||
| SelectContent, | ||
| SelectItem, | ||
| SelectTrigger, | ||
| SelectValue, | ||
| } from "@/components/ui/select"; | ||
| import { | ||
| RUN_FILTER_STATUSES, | ||
| type RunFilters, | ||
| type RunFilterStatus, | ||
| } from "@/lib/run-filters"; | ||
| import { getRunStatusConfig } from "@/lib/status"; | ||
| import { useState } from "react"; | ||
|
|
||
| interface RunFiltersFormProps { | ||
| filters: RunFilters; | ||
| onChange: (filters: RunFilters) => void; | ||
| } | ||
|
|
||
| export function RunFiltersForm({ filters, onChange }: RunFiltersFormProps) { | ||
| const [status, setStatus] = useState(filters.status); | ||
| const [workflowName, setWorkflowName] = useState(filters.workflowName ?? ""); | ||
|
|
||
| return ( | ||
| <form | ||
| aria-label="Filter workflow runs" | ||
| className="flex flex-wrap items-end gap-3" | ||
| onSubmit={(event) => { | ||
| event.preventDefault(); | ||
| onChange({ status, workflowName: workflowName.trim() || undefined }); | ||
| }} | ||
| > | ||
| <Field className="w-full sm:w-44"> | ||
| <FieldLabel htmlFor="run-filter-status">Status</FieldLabel> | ||
| <Select<RunFilterStatus | "all"> | ||
| value={status ?? "all"} | ||
| onValueChange={(value) => { | ||
| setStatus(value === "all" || value === null ? undefined : value); | ||
| }} | ||
| > | ||
| <SelectTrigger id="run-filter-status" className="w-full"> | ||
| <SelectValue> | ||
| {status ? getRunStatusConfig(status).label : "All statuses"} | ||
| </SelectValue> | ||
| </SelectTrigger> | ||
| <SelectContent> | ||
| <SelectItem value="all">All statuses</SelectItem> | ||
| {RUN_FILTER_STATUSES.map((value) => ( | ||
| <SelectItem key={value} value={value}> | ||
| {getRunStatusConfig(value).label} | ||
| </SelectItem> | ||
| ))} | ||
| </SelectContent> | ||
| </Select> | ||
| </Field> | ||
| <Field className="w-full sm:w-64"> | ||
| <FieldLabel htmlFor="run-filter-workflow">Workflow name</FieldLabel> | ||
| <Input | ||
| id="run-filter-workflow" | ||
| name="workflowName" | ||
| placeholder="Exact workflow name" | ||
| value={workflowName} | ||
| onChange={(event) => { | ||
| setWorkflowName(event.currentTarget.value); | ||
| }} | ||
| /> | ||
| </Field> | ||
| <Button type="submit">Apply filters</Button> | ||
| <Button | ||
| type="button" | ||
| variant="ghost" | ||
| onClick={() => { | ||
| setStatus(undefined); | ||
| setWorkflowName(""); | ||
| onChange({}); | ||
| }} | ||
| > | ||
| Clear filters | ||
| </Button> | ||
| </form> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { | ||
| validateRunsPaginationSearch, | ||
| type RunsPaginationSearch, | ||
| } from "./runs-page-pagination"; | ||
| import type { WorkflowRunCounts } from "openworkflow/internal"; | ||
| import * as z from "zod"; | ||
|
|
||
| export const RUN_FILTER_STATUSES = [ | ||
| "pending", | ||
| "running", | ||
| "completed", | ||
| "failed", | ||
| "canceled", | ||
| ] as const satisfies readonly (keyof WorkflowRunCounts)[]; | ||
|
|
||
| export const runFiltersSchema = z.object({ | ||
| status: z.enum(RUN_FILTER_STATUSES).optional(), | ||
| workflowName: z | ||
| .string() | ||
| .trim() | ||
|
There was a problem hiding this comment.
A workflow created through |
||
| .transform((value) => value || undefined) | ||
| .optional(), | ||
| }); | ||
|
|
||
| export type RunFilters = z.infer<typeof runFiltersSchema>; | ||
| export type RunFilterStatus = (typeof RUN_FILTER_STATUSES)[number]; | ||
| export type RunsPageSearch = RunsPaginationSearch & RunFilters; | ||
|
|
||
| export function validateRunsSearch( | ||
| // oxlint-disable-next-line anti-slop/no-unknown-parameters -- URL search values are untrusted until validated | ||
| search: unknown, | ||
| ): RunsPageSearch { | ||
| const pagination = validateRunsPaginationSearch(search); | ||
| const filters = runFiltersSchema.safeParse(search); | ||
| if (!filters.success) return pagination; | ||
| return { ...pagination, ...filters.data }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For databases with older runs stored as
sleepingorsucceeded, clicking Running or Completed excludes runs counted by that card.toWorkflowRunCountsfolds these older statuses into the displayed counts, butlistWorkflowRunsmatches the requested status exactly. The migrations do not rewrite those statuses, so a nonzero card can lead to an empty list. Make the dashboard filters include the same statuses as the counts.