Repository navigation
fix: theming minor corrections - #64
Merged
Merged
Conversation
- design tokens should include the "-theme-" keyword - styling should be applied to :host, not every sub element - allow css to do its thing
stee-re
requested review from
clepski and
danyill
and removed request for
danyill
September 30, 2026 08:14
clepski
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Correct the palette token names. The supported distribution-facing tokens use the --oscd-theme-* prefix. The table previously listed internal --oscd-* aliases, which could lead consumers to set the wrong properties.
• Scope the examples to :host instead of * . Define mappings once on the plugin root and let CSS inheritance carry them to descendants. Declaring them on every element prevents subtree overrides from taking effect through inheritance.