Repository navigation
Fix senkin_tmp predictions check - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In run_2026-09-28
senkin_tmp_predictstill failed on every CITE dataset, now withAssertionError: test cells do not match the trained model. The cell names are identical, but the train image (pandas 3) writes the index ofpredictions.h5adas astringdtype and the predict image (pandas 2.3) reads the test cells asobject, soIndex.equals()returnsFalse.Describe your changes
senkin_tmp_predict: compareobs_namesandvar_namesas lists.models/senkin_tmp/predictions.h5ad), which only held the oldmodel.pklthat the predict image cannot unpickle.Checked on de.NBI against the failing
pbmc_cite/normalinputs with the 0.2.0-rc6 image.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!