Skip to content

Add pressure to gas-phase compute config - #204

Merged
mattwthompson merged 5 commits into
mainfrom
pressure-in-gas-config
Oct 19, 2026
Merged

mattwthompson merged 5 commits into
mainfrom
pressure-in-gas-config

Conversation

@mattwthompson

Copy link
Copy Markdown
Member

Closes #203

@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.61%. Comparing base (e6f019a) to head (57ee83a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   83.44%   83.61%   +0.17%     
==========================================
  Files          58       58              
  Lines        5195     5195              
==========================================
+ Hits         4335     4344       +9     
+ Misses        860      851       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change is correct and tested, but a leftover, confusing comment in the new test fixture should be removed before approval.

1 open issue
What changed in this PR

This PR fixes issue #203, where the pressure measured in a thermophysical property target was not propagated to the gas-phase compute config. Because tyff.TensorReporter (and the equilibrate/produce steps) require a pressure argument even for gas-phase NVT runs, the missing key caused a PressureNotDefinedError/Parsl failure. The fix promotes pressure to the shared BaseComputeConfig and ensures the VacuumGas config receives it.

Changes:

  • Moved pressure: float from BulkLiquid up into the shared BaseComputeConfig TypedDict so both liquid and gas configs carry it.
  • Populated pressure on the VacuumGas config in _make_enthalpy_of_vaporization_compute_configs.
  • Added a dhvap_entry fixture and a test_pressure_in_gas_configs test verifying pressure is present in all generated configs.
File Description
tyff/​configs/​_compute.py Adds pressure to the base compute config so all phases inherit it.
tyff/​configs/​liquid.py Removes the now-redundant pressure field from BulkLiquid.
tyff/​compute/​prep.py Passes pressure into the gas-phase (VacuumGas) config.
tyff/​_tests/​conftest.py Adds a dhvap_entry fixture for the enthalpy-of-vaporization case.
tyff/​_tests/​compute/​test_prep.py Adds a test asserting pressure is present in generated configs.

Review effort: Balanced

Comment thread tyff/_tests/conftest.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mattwthompson
mattwthompson marked this pull request as ready for review October 19, 2026 19:36
@mattwthompson
mattwthompson merged commit 6f3e337 into main Oct 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gas-phase pressure not passed from physical property target to compute configs

3 participants