Repository navigation
fix!: gate the forum HTTP API behind a toggle and require a staff caller - #298
Merged
Merged
Conversation
The fix for GHSA-c6fp-f54c-6cv4 landed on master as 322ca14, but merging from the security advisory replaced its conventional-commit subject with "Merge commit from fork", so python-semantic-release could not parse it, missed its BREAKING CHANGE footer, and made no release. This commit restates that change so the next Release run publishes it, and documents the FORUM_ENABLE_HTTP_API setting in the README. GHSA-c6fp-f54c-6cv4 BREAKING CHANGE: The forum HTTP API under /forum/api/v1/ and /forum/api/v2/ is no longer routed unless FORUM_ENABLE_HTTP_API is set to True, and when routed it rejects callers that are not authenticated as a staff account. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for GHSA-c6fp-f54c-6cv4 landed on
masterin 322ca14, but merging from the advisory replaced its subject with "Merge commit from fork". Semantic release could not parse it, missed theBREAKING CHANGEfooter, and the last Release run decidedno_release: https://github.com/openedx/forum/actions/runs/38577743442This restates the change as a
fix!:commit with the breaking change footer and adds a README section forFORUM_ENABLE_HTTP_API. A localsemantic-release --noop version --printwith this commit onmastergives0.5.0.This needs to be rebase merged so the commit message lands on
masteras-is.🤖 Generated with Claude Code