Repository navigation
test: authenticate the e2e API client as the forum service user (0.4.2.x) - #297
Merged
Merged
Conversation
The forum HTTP API now requires a staff caller (GHSA-c6fp-f54c-6cv4), and tests/conftest.py's api_client fixture logs in as a staff service account for that reason. tests/e2e/conftest.py overrode that fixture with an anonymous client, so every e2e request got a 403. Drop the override so the e2e suite uses the authenticated fixture from tests/conftest.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The py env runs the same commands as django42 and django52 but leaves Django unpinned, so it installs whatever Django release is newest. This release/0.4.2.x backport branch is not expected to work with the latest unpinned Django: Django 6.1 removed django.utils.cache.cc_delim_re, which the djangorestframework 3.16.1 pinned here still imports, so the py job fails before any test runs. The supported Django versions are still covered by the django42 and django52 envs, which are also the only ones in tox's envlist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
feanil
marked this pull request as ready for review
October 14, 2026 14:14
Like py, the e2e env installed requirements/test.txt, which has its Django line stripped, and nothing else pinned Django, so it got the newest release (6.1.2). This release/0.4.2.x backport branch is not expected to work with the latest unpinned Django: Django 6.1 removed django.utils.cache.cc_delim_re, which the pinned djangorestframework 3.16.1 still imports. Pin e2e to the Django 5.2 line this branch's requirements/quality.txt already pins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #294 to
release/0.4.2.x. The forum HTTP API now requires a staff caller (GHSA-c6fp-f54c-6cv4), andtests/e2e/conftest.pyoverrode the authenticatedapi_clientfixture with an anonymous client, so every e2e request got a 403. Locallypytest tests/e2egives 74 passed with this change.The other two commits fix CI on this branch, which is not expected to work with the latest unpinned Django: Django 6.1 removed
cc_delim_re, which the pinned DRF 3.16.1 still imports. Thepyenv is dropped from the CI matrix since it only differs fromdjango42/django52by leaving Django unpinned, and thee2eenv is pinned to Django 5.2 to matchrequirements/quality.txt.🤖 Generated with Claude Code