Repository navigation
fix: pin drf-yasg below 1.21.17 to unbreak collectstatic - #3010
GlugovGrGlib wants to merge 1 commit into
Conversation
drf-yasg 1.21.17 ships redoc-old/redoc.min.js ending with '//# sourceMappingURL=redoc.min.map', while the bundled source map is redoc.min.js.map. ManifestStaticFilesStorage follows the reference and collectstatic fails, breaking unit_tests in the requirements bot PR (openedx#3009). This is the same regression drf-yasg had in 1.21.6 (axnsan12/drf-yasg#855).
|
Thanks for the pull request, @GlugovGrGlib! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@feanil should we be updating this repo to use the latest API doc tooling so we can remove this dependency? It looks like there have been no updates to this dependency upstream in a year. |
|
Yes, We should move this to DRF spectacular like we have done so with openedx-platform. I'll create an issue and follow up on that. |
Description
The requirements bot PR #3009 fails
unit_testsbefore any test runs:make staticcrashes incollectstatic:Cause: drf-yasg 1.21.17 (bumped from 1.21.15 in #3009) changed the last line of
static/drf-yasg/redoc-old/redoc.min.jsfrom//# sourceMappingURL=redoc.min.js.mapto//# sourceMappingURL=redoc.min.map, but the wheel still ships the map asredoc.min.js.map.ManifestStaticFilesStorageresolves source-map references and fails on the missing file. I confirmed this by diffing the 1.21.15 and 1.21.17 wheels. It's the same packaging regression drf-yasg had in 1.21.6 (axnsan12/drf-yasg#855). The Django 5.2.17 → 5.2.18 bump in the same PR is not involved.This PR adds
drf-yasg<1.21.17torequirements/constraints.txt, with a comment explaining when to remove it. Compiled.txtfiles on master are already at 1.21.15, so nothing else changes here; the next bot run (or a re-run of the Upgrade Requirements workflow) will regenerate #3009 with the pin applied.Verified with pip-compile that the constraint resolves to
drf-yasg==1.21.15together withdjango==5.2.18.