feat(tools): support tool search (defer_loading=true) in typed function helpers - #1144
Conversation
|
@codex review pls |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review pls |
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 91 mixed files remain; 1 existing customization changed. Compared
90 existing customizations unchanged
50 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 37345178918 --repo openai/openai-java \
--name castiron-custom-code-37345178918-1 --dir /tmp/castiron-custom-code-37345178918-1
git apply --stat /tmp/castiron-custom-code-37345178918-1/custom-code.patch
cat /tmp/castiron-custom-code-37345178918-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin c50d94b56e76317888b7018fd51c6704c89865b5 65a5cda206859e904eabacfeca7c5752bc06f4b6
python3 scripts/castiron/custom_code_report.py report \
--base c50d94b56e76317888b7018fd51c6704c89865b5 \
--head 65a5cda206859e904eabacfeca7c5752bc06f4b6 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-65a5cda20685
cat /tmp/castiron-custom-code-65a5cda20685/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review pls |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review pls |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 65a5cda206859e904eabacfeca7c5752bc06f4b6. The class-derived Responses tool customizer reuses schema generation and validation, including through the structured builder. Agents withDeferLoading returns a new definition while retaining the typed sync/async handler and the existing default. The request and streaming tests cover the option and typed argument decoding.
Hosted tests, API compatibility, Jackson compatibility, Java 8/25 runtime checks, build and lint passed on this head. Source review only; no local tests or live API calls were run. The live smoke results in the request are author-reported.
Summary
Configure deferred loading without rebuilding a class-derived function schema or separating an Agents tool definition from its typed handler.
Responses, before:
After, including structured-response builders:
Agents, before:
After:
withDeferLoadingreturns an immutable binding and also supportsofAsync. Explicit true/false values are preserved; existing defaults, schema validation, argument parsing, and handler execution remain unchanged. Tool-search configuration is validated by the API.