Skip to content

[RFC] Refactor SumAggregation to be strongly typed - #4731

Open
marcalff wants to merge 3 commits into
open-telemetry:mainfrom
marcalff:fix_aggregation
Open

marcalff wants to merge 3 commits into
open-telemetry:mainfrom
marcalff:fix_aggregation

Conversation

@marcalff

Copy link
Copy Markdown
Member

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff
marcalff requested a review from a team as a code owner October 24, 2026 19:37
@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.39024% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.73%. Comparing base (ac7b87a) to head (8ae93b4).

Files with missing lines Patch % Lines
exporters/prometheus/src/exporter_utils.cc 62.97% 10 Missing ⚠️
sdk/src/metrics/aggregation/sum_aggregation.cc 82.15% 5 Missing ⚠️
exporters/ostream/src/metric_exporter.cc 75.00% 2 Missing ⚠️
...ude/opentelemetry/sdk/metrics/data/exemplar_data.h 66.67% 2 Missing ⚠️
exporters/otlp/src/otlp_metric_utils.cc 88.89% 1 Missing ⚠️
...pentelemetry/sdk/metrics/exemplar/reservoir_cell.h 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4731      +/-   ##
==========================================
+ Coverage   86.69%   86.73%   +0.04%     
==========================================
  Files         527      527              
  Lines       20902    20900       -2     
==========================================
+ Hits        18119    18125       +6     
+ Misses       2783     2775       -8     
Files with missing lines Coverage Δ
...etry/sdk/metrics/aggregation/default_aggregation.h 86.59% <100.00%> (ø)
...elemetry/sdk/metrics/aggregation/sum_aggregation.h 0.00% <ø> (ø)
...nclude/opentelemetry/sdk/metrics/data/point_data.h 58.70% <ø> (ø)
exporters/otlp/src/otlp_metric_utils.cc 92.15% <88.89%> (+0.17%) ⬆️
...pentelemetry/sdk/metrics/exemplar/reservoir_cell.h 97.83% <50.00%> (ø)
exporters/ostream/src/metric_exporter.cc 85.81% <75.00%> (-0.55%) ⬇️
...ude/opentelemetry/sdk/metrics/data/exemplar_data.h 71.43% <66.67%> (-28.57%) ⬇️
sdk/src/metrics/aggregation/sum_aggregation.cc 82.36% <82.15%> (+15.36%) ⬆️
exporters/prometheus/src/exporter_utils.cc 87.50% <62.97%> (-1.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant