Repository navigation
Conversation
mateenali66
reviewed
Oct 24, 2026
mateenali66
left a comment
Member
There was a problem hiding this comment.
built cda0cd10 (macOS, ABI v1), 1147/1147 tests pass. three things for when this becomes real PRs.
MetricReader::Collectlosing noexcept makes the catch inPeriodicExportingMetricReader::CollectAndExportOnce()reachable, and it returns before advancingforce_flush_notified_sequence_(periodic_exporting_metric_reader.cc:184-204). with an exporter whoseExport()throws,ForceFlush(2s)times out andMeterProvider::Shutdown()with the default timeout never returns.Span::Spanand its attribute lambda stay noexcept (span.cc:62, :81), so a throwingOnStart()terminates insideStartSpan()before the catch at tracer.cc:170. #4700 now catches inside each exporter'sMakeRecordable(), the opposite convention.- part of the clang-tidy drop is the check not seeing through pure virtuals. with
TreatFunctionsWithoutSpecificationAsThrowing: OnlyUndefined(clang-tidy 23) new escapes show atSpan::SpanandLogger::EmitLogRecord.
is TracerProvider::Shutdown() meant to stay an entry point? a throwing exporter Shutdown() now reaches the caller.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes