Repository navigation
test(playwright): de-flake CustomPropertiesPanel edit, ProfileTeam search and PersonaSettings curated widget - #36652
Conversation
…arch and PersonaSettings curated widget - CustomPropertiesPanel: run the edit test on the worksheet type, which no other spec mutates, so a parallel write to the shared table type cannot overwrite the edit. - ProfileTeam: re-fill the debounced team search until the term sticks and the table shows its result; the echoed previous term could revert the input. - PersonaSettings: re-apply the persona deep link when the boot drops its hash, and re-pick the query-builder operator until the rule reads "Contains" and holds its value.
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
…e the curated-assets count Replace the PersonaSettings retry loops with deterministic waits: - openPersonaSettings boots through redirectToHomePage and opens the hash deep link inside the running app, so the boot's redirects cannot drop it. The custom-properties wait only counts requests issued after it is armed. - The Curated Assets test waits for the asset-count request fired by the Table pick and its banner before building the rule; the banner rendering under an open dropdown moved the options and picked "Not in".
… next term Replace the ProfileTeam re-fill loop: the debounced search writes the applied term back into the input, so a term typed before that overwrote it. Wait until the table lists only the searched team, which is the render that applies the term, then search again.
…fore the next term
🚦 Removed from the merge queue —
|
Code Review ✅ Approved🟢 Low risk · These changes adjust Playwright setup, waits, and test data isolation only, leaving application behavior and public interfaces unchanged. Test-only de-flake of three Playwright specs: CustomPropertiesPanel edit now uses the isolated worksheet type, ProfileTeam search waits for each step's result before continuing, and PersonaSettings curated widget opens its deep link inside the running app and waits for the asset count before picking rule values. No issues found. VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
Fixes the merge-queue flakes reported by the Playwright Flaky Daily Report run 40998300289:
Features/AIMode/CustomPropertiesPanel.spec.ts› edits a custom property display name and descriptionPages/AIProfile/ProfileTeam.spec.ts› Should search teams in the Organization sub-teams tableFeatures/AIMode/PersonaSettings.spec.ts› Home page: a configured Curated Assets widget is savedWhy they started on 2026-10-29: none of these tests appears in any earlier daily report, and neither the tests nor their features changed. The CI shard planner packs specs by rolling timing history, and #35902 reshaped its lanes. After the repack these tests ran next to new neighbours under more load. For example, CustomPropertiesPanel moved into the same shard as
Pages/CustomProperties.spec.ts. That exposed timing races in the tests. Evidence comes from the CI blob reports' failure snapshots.Initial description. Parallel specs, and sibling tests in this spec, were adding and removing properties on the sharedtabletype in the same second and overwrote the edit.worksheettype. No other spec adds, edits or removes worksheet custom properties; onlyentity-data-setuptouches it, before the tests run. The helpers take the type as a parameter and default totable.Type of change:
High-level design:
N/A — test-only change to three specs.
Tests:
Use cases covered
Unit tests
Not applicable (no app code changes).
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
CustomPropertiesPanel.spec.ts,ProfileTeam.spec.ts,PersonaSettings.spec.tsManual testing performed
None beyond the Playwright runs above.
UI screen recording:
Not applicable — test-only change.
Checklist:
🤖 Generated with Claude Code