CI: don't hide installer build failures and exclude stale ENV specs - #487
Closed
fs-bmedkouri wants to merge 1 commit into
Closed
fs-bmedkouri wants to merge 1 commit into
fs-bmedkouri wants to merge 1 commit into
Conversation
…specs "rake ... & gpgconf --kill all" returned the exit code of gpgconf, so a failing installer build only surfaced in the following step. Ruby-4.0.7 and 3.4.11 return ENV keys in UTF-8 on Windows (backport of https://bugs.ruby-lang.org/issues/20958), but the specs bundled with these tags still expect the locale encoding. ruby/spec fixed this in ruby/spec@af6351a
larskanis
added a commit
that referenced
this pull request
Oct 2, 2026
Member
|
Thank you for this PR! I picked the early failure exit patch, but merged #488 instead for the spec fix. I try to avoid any exclusion of tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI fixes:
1. The "Build the installer" step can't fail.
rake ... & gpgconf --kill allreturns the exit code ofgpgconf, so a failingrake ri:...is reported as success and only shows up in the next step (e.g. the currentheadfailure surfaces in "Build the RubyInstaller-Devkit installer"). The step now keeps rake's exit code and still kills gpg-agent.2. Stale ENV specs on 4.0.7 and 3.4.11. "Run the MRI copy of Ruby Spec Suite" fails on all 4.0.7 and 3.4.11 jobs since those versions were added (run):
Both releases backport Bug #20958 (ENV keys in UTF-8 on Windows; ruby/ruby@137e40a, ruby/ruby@d784a0b), but the specs bundled in these tags weren't updated. ruby/spec already adjusted the guard (ruby/spec@af6351a). The two examples are excluded until the release branches pick that up. mspec's
--excludeis a substring match, so the new "UTF-8" examples on head still run.Verification: I checked the exit-code handling locally with the same
cmd /D /E:ON /V:OFF /S /C "CALL ..."wrapper Actions uses, against a.batthat exits 7: the gpgconf line ran and the step exited 7. The full matrix was not run; this PR's CI is the end-to-end check.