Repository navigation
Fix SSH config to allow either a public key or known hosts file to be set - #885
Merged
Merged
Conversation
m90
reviewed
Oct 22, 2026
m90
reviewed
Oct 22, 2026
| if c.SSHHostName != "" && !c.SSHInsecureIgnoreHostKey && (c.SSHHostPublicKey == "" || c.SSHKnownHostsFile != "") { | ||
| err = errwrap.Wrap(nil, "SSH hostname given without a public key or known_hosts, refer to the documentation for guidance") | ||
| return | ||
| if c.SSHHostName != "" && !c.SSHInsecureIgnoreHostKey { |
Member
There was a problem hiding this comment.
Thanks, that's already easier on the eye. I'll merge and release this once CI is green.
Member
|
This is now released in v2.49.3, thanks a lot for taking care of this so quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to update my setup to v2.49.2 I've noticed that I cannot set
SSH_KNOWN_HOSTS_FILE. The current config validation requiresSSH_HOST_PUBLIC_KEYto be always set andSSH_KNOWN_HOSTS_FILEto never be set