Repository navigation
Fix catalog-target request bodies (ISSUE-156) and Service Level Objective map fields (ISSUE-157) - #464
Merged
dwolfson merged 1 commit intoOct 19, 2026
Conversation
…SUE-157) ISSUE-156: AutomatedCuration.add_catalog_target and update_catalog_target posted a flat "CatalogTargetRequestBody", a class Egeria does not have, so the platform refused them. They now send NewRelationshipRequestBody / UpdateRelationshipRequestBody with CatalogTargetProperties (matching AssetMakerResource), keeping the existing signatures. template_properties maps to Egeria's "templates" field, which the old body also misnamed. ISSUE-157: set_gov_prop_body defaulted entitlements, obligations and restrictions to [], but Egeria types them as Map<String, String> (TermsAndConditionsProperties and subtypes such as ServiceLevelObjectiveProperties), so Create Service Level Objective was refused. They now default to None. Micro-tests: tests/micro-tests/test_issue_156_157_catalog_target_slo.py; full micro-test suite passes in a clean python:3.13-slim container. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
dwolfson
added a commit
that referenced
this pull request
Oct 19, 2026
Ships the ISSUE-156 (AutomatedCuration add/update_catalog_target request bodies) and ISSUE-157 (Dr.Egeria Create Service Level Objective map fields) fixes from #464. BACKLOG.md: the delete re-tests ran on Egeria main 05a5e982; only ISSUE-146's remove_note re-test is still open. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two pyegeria 6.2.5 defects reported by the Egeria team (PYEGERIA_ISSUES.md ISSUE-156 and ISSUE-157).
ISSUE-156: catalog-target request bodies
AutomatedCuration.add_catalog_targetandupdate_catalog_targetposted a flat body with"class": "CatalogTargetRequestBody". Egeria has no such class, so the platform refused both calls.AssetMakerResource.addCatalogTargettakesNewRelationshipRequestBody, andupdateCatalogTargettakesUpdateRelationshipRequestBody; both expectCatalogTargetProperties._async_new_relationship_request/_async_update_relationship_requesthelpers.template_propertiesnow maps to Egeria'stemplatesfield; the old body named ittemplateProperties.hey_egeriaadd_catalog_targetcommand calls this method, so it is fixed too.AssetMaker.add_catalog_targetalready sent the right shape and is unchanged.ISSUE-157: Dr.Egeria
Create Service Level Objectiveset_gov_prop_bodydefaultedentitlements,obligationsandrestrictionsto[]for every governance definition. Egeria types them asMap<String, String>(TermsAndConditionsPropertiesand subtypes such asServiceLevelObjectiveProperties), so Create Service Level Objective got a 400MismatchedInputExceptiononentitlements. The defaults are nowNone. Other governance types never had these fields and ignored them.Testing
tests/micro-tests/test_issue_156_157_catalog_target_slo.pycheck the request bodies and the SLO property defaults. The full micro-test suite (1,394 tests) passes in a cleanpython:3.13-slimcontainer with no Egeria.main05a5e982, using throwaway elements that were deleted and verified gone afterwards:implementationDescriptionintact.🤖 Generated with Claude Code