Repository navigation
My Profile: one key binding convention on every screen; make Roles -> My Team discoverable - #463
Merged
Merged
Conversation
Co-authored-by: Junie <junie@jetbrains.com> Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…w peers - Load the user's profile and existing Peer relationships on mount - Search actor profiles (case-insensitive) instead of user identities - Add description input and a Link Peer button to create the relationship Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…, added custom report format for listing peers Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
… of the custome report format Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Merge the experimental my_network.py functionality into the My Profile app as a "My Network" option: list the user's peers, search for people and add them, view a peer's contact methods and communities, and remove a peer (with confirmation) via unlink_peer_person. - network_handler.py: NetworkMixin doing the Egeria calls - MyNetworkScreen.py: network screen and remove-confirmation dialog - my_network.py: add Remove from Network button with confirmation, hide stale details after removal - my_profile_report_specs.json: fix invalid JSON, query the Peer relationship, and show the person's GUID - tests for the mixin, screen and option routing Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
TechnologyTypesScreen dismisses quit/go back with the strings "200"/"201", but tech_type_callback compared against the int 201. The back result was then treated as a tech type name, get_tech_type_detail returned the string "No elements found", and .get() on it raised AttributeError. - match "200"/"201" as either str or int and return to the main screen - if the tech type detail is not a dict, notify and return to the main screen instead of crashing - stop after showing the error screen when the detail lookup fails - use the Egeria client for get_tech_type_detail Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
- user manual: My Network section (view details, search and add, remove with confirmation), keyboard reference rows, intro mention - reference guide: NetworkMixin section with sequence diagram and function table, plus source layout, class diagram, menu dispatch, report spec, client and testing updates Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Restore config/config.json and test_classification_manager.py to their upstream versions. The config change pointed the report spec modules and log directory at local absolute paths, and the test change was local debugging of the Peer relationship query. Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
- go back/quit as "201"/"200" (str or int) returns to the main screen without looking up a tech type - a string detail result such as "No elements found" notifies and returns to the main screen - patch Egeria rather than AutomatedCuration, matching the handler, so the callback tests no longer try to reach the server - a failed detail lookup now pushes only the StatusScreen Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
The screen's prompt was a TextArea, which took focus when the screen opened. A focused TextArea consumes printable keys, so b (go back), q, s, u, t and k did nothing and Textual hid them from the footer. - make the prompt a Static, and mention b/Escape in it - add Escape as a go-back key (not shown in the footer) - move Go back next to Quit so it isn't cut off on narrow terminals - tests: b and Escape pressed straight after the screen opens dismiss with [200]; the callback returns [200] to the main screen - user manual: document Escape on Shop for Data Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Every screen now follows the same rules: - escape goes back one level (every screen except Main) - q is the only plain-letter key: main menu on list screens, quit on Main; left off text-entry forms, where it would be typed into the Input - every other action is a ctrl key with one meaning app-wide: ctrl+s submit, ctrl+n add, ctrl+d delete, ctrl+o open, ctrl+k/ctrl+b bookmark row/bookmarks, ctrl+u subscribe, ctrl+l sample, ctrl+g glossary search, ctrl+y copy GUID, ctrl+r refresh (was r) Return codes are unchanged; only the keys moved. Also fixes keys that could never fire: ctrl+i (sent as Tab) and ctrl+c on Edit Profile, the "return" key name on Status and the sample-data view, and the Technology Types quit/go back mix-ups. Adds ctrl+s to Create/Edit Profile. MainScreen shows the user name as its subtitle; its config logging moves to on_mount, since self.log needs a running app. test_key_bindings.py enforces the convention; docs updated to match. Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…-profile-strict-tests Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…s to User Identities Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…ests Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> # Conflicts: # docs/my_profile_app_manual.md # my_egeria/my_egeria/DemoCode/My_Profile/MyNetworkScreen.py # my_egeria/my_egeria/DemoCode/My_Profile/ShopForDataScreen.py # tests/micro-tests/my_profile/test_screens.py
pcoldico
marked this pull request as ready for review
October 19, 2026 13:27
dwolfson
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One key binding convention on every screen
Every My Profile screen now follows the same rules:
Escapegoes back one level (every screen except Main).qis the only plain-letter key: Main Menu on sub-screens, Quit on Main. It is left off text-entry forms, where it would be typed into the Input.ctrlkey with one meaning app-wide:ctrl+ssubmit,ctrl+nadd,ctrl+ddelete,ctrl+oopen,ctrl+k/ctrl+bbookmark row/bookmarks,ctrl+usubscribe,ctrl+lsample,ctrl+gglossary search,ctrl+ycopy GUID,ctrl+rrefresh (wasr).Return codes are unchanged; only the keys moved. This also fixes keys that could never fire:
ctrl+i(sent as Tab) andctrl+con Edit Profile, thereturnkey name on Status and the sample-data view, and the Technology Types quit/go back mix-ups. Create/Edit Profile gainctrl+s. MainScreen shows the user name as its subtitle, and its config logging moves toon_mount, sinceself.logneeds a running app.Make the Roles -> My Team view discoverable
Selecting a TeamLeader/TeamMember role opens the My Team screen, but nothing on screen said so, and selecting any other role did nothing.
440.Other Functions menu
Docs
docs/my_profile_app_manual.mdanddocs/developer_guide_pyegeria_textual.mdupdated for the new keys; the manual also describes the Roles -> My Team behaviour.RETURN_CODES.mdnow limit440to glossary lookups.Testing
tests/micro-tests/my_profile/test_key_bindings.pyenforces the key convention on every screen.test_team_roles_handler.pycovers the non-team warning, the no-exit error path, and that a failed lookup shows only the status screen.pytest tests/micro-tests/my_profile/: 533 passed, 1 skipped (with the ISSUE-153 tests merged from main). The team-roles tests also pass live (PYEG_LIVE_EGERIA=1).🤖 Generated with Claude Code