Repository navigation
feat: batch methods - #64
InvalidJoker wants to merge 3 commits into
Conversation
Assisted-By: Claude Opus 5.5
bcdd244 to
9218031
Compare
|
Why? If the reason for a feature is not obvious, you must provide it. Either in this pull request or in the commit msg. The later is preferred. |
reason for this is because of the modpack installer and other upcomming features which download many files at once which would be pretty dumb to do one request for every file |
|
Not sure why. reqwest uses connection pooling and supports http2, so a new request does not mean a new connection (there will likely even be idle connections in the pool). Axum and reqwest can handle 100 requests at the same time without any issues. In case of download, there should be no disadvantage of calling write_file_by_url 100x times over using a batch method. Well, it will open 100x requests to the download target though currently, so maybe a global request limit per host makes sense. But overall, results in the same behavior. Even more so for file operations. |
|
Well I guess it probably has some benefits doing it that way, but it also makes the code more convoluted. Not sure if its worth the trade. |
No description provided.